[MOB-12231] Put all calls to the native layer in a class called IterableApi #737

lposen · 2025-10-10T20:32:26Z

🔹 JIRA Ticket(s) if any

MOB-12231

✏️ Description

Extract native layer functions so that they are all listed in one place

Testing

There is no functionality change, so you can just make sure the app builds and logs in on either android or ios

…rable class

github-actions · 2025-10-10T20:34:02Z

Lines	Statements	Branches	Functions
	49.79% (243/488)	23.31% (45/193)	52.55% (103/196)

qltysh · 2025-10-10T20:34:14Z

Diff Coverage: The code coverage on the diff in this pull request is 86.9%.

Total Coverage: This PR will increase coverage by 1.6%.

File Coverage Changes

Path	File Coverage Δ	Indirect
src/core/classes/Iterable.ts	-3.3
src/core/classes/IterableApi.ts	100.0
src/core/classes/IterableLogger.ts	-25.0	√
src/inbox/classes/IterableInboxDataModel.ts	0.2

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

qltysh · 2025-10-10T20:34:23Z

All good ✅
_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

src/core/classes/IterableApi.ts

… parameters

…lure' into jwt/MOB-12231-create-an-iterableapi-class-for-api-calls

github-actions · 2025-10-10T21:39:59Z

🚀 Deployed on https://jwt-mob-12231-create-an-iterableapi-class-for-api-calls--iterable-react-native-sdk.netlify.app

example/ios/ReactNativeSdkExample/AppDelegate.swift

…ndencies

…lure' into jwt/MOB-12231-create-an-iterableapi-class-for-api-calls

…ass-for-api-calls

Copilot

Pull Request Overview

Centralizes all direct native layer interactions into a new IterableApi class and refactors existing classes (Iterable, IterableInAppManager, IterableInboxDataModel, IterableAuthManager) to use it. Adds comprehensive unit tests for IterableApi and updates exports.

Introduces IterableApi wrapper consolidating native bridge calls
Refactors existing classes to delegate to IterableApi (removing duplicated native calls and most logging)
Adds extensive test coverage for IterableApi methods

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/inbox/classes/IterableInboxDataModel.ts	Refactors inbox data model methods to use IterableApi instead of RNIterableAPI.
src/inApp/classes/IterableInAppManager.ts	Refactors in-app manager to delegate to IterableApi and adds usage example.
src/core/classes/index.ts	Re-exports IterableApi and IterableAuthManager.
src/core/classes/IterableAuthManager.ts	Switches to IterableApi for auth-related native calls.
src/core/classes/IterableApi.ts	New centralized wrapper encapsulating all native layer interactions.
src/core/classes/IterableApi.test.ts	Adds comprehensive tests for all IterableApi methods.
src/core/classes/Iterable.ts	Refactors to route native operations through IterableApi and simplifies in-app manager instantiation.
src/mocks/MockRNIterableAPI.ts	Adapts mock to support new usage patterns (jest.fn wrappers, added methods).

Comments suppressed due to low confidence (1)

src/core/classes/Iterable.ts:352

IterableApi.getAttributionInfo already returns an IterableAttributionInfo | undefined; this extra then block redundantly re-wraps the object. Simplify by returning IterableApi.getAttributionInfo() directly to reduce duplication.

    return IterableApi.getAttributionInfo().then(
      (
        dict: {
          campaignId: number;
          templateId: number;
          messageId: string;
        } | null
      ) => {
        if (dict) {
          return new IterableAttributionInfo(
            dict.campaignId as number,
            dict.templateId as number,
            dict.messageId as string
          );
        } else {
          return undefined;
        }

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/inApp/classes/IterableInAppManager.ts

lposen · 2025-10-15T17:29:57Z

The only functionality to check is actually IterableApi.ts.

The rest is just testing an a name change.

Ayyanchira

LGTM

Ayyanchira · 2025-10-15T17:42:55Z

src/inbox/classes/IterableInboxDataModel.ts

   * @param id - The unique identifier of the message to be marked as read.
   */
  setMessageAsRead(id: string) {
-    Iterable?.logger?.log('IterableInboxDataModel.setMessageAsRead');


Do we not want Logging? Native layer had some extra debug logs to understand internal working of SDK.

We do, but these logs are now done whenever any function in IterableApi is called. They're still there, they just moved locations.

Ayyanchira · 2025-10-15T17:43:32Z

src/inbox/classes/IterableInboxDataModel.ts

-    );
-
-    return RNIterableAPI.getHtmlInAppContentForMessage(id).then(
+    return IterableApi.getHtmlInAppContentForMessage(id).then(


Acknowledging RN prefix is getting removed and its more on-par with native SDKs

Oh... that's good to know!

Ayyanchira · 2025-10-15T20:20:25Z

src/inApp/classes/IterableInAppManager.ts

@@ -1,4 +1,4 @@
-import { RNIterableAPI } from '../../api';
+import { IterableApi } from '../../core/classes/IterableApi';


Good to see RNIterable is now Iterable

Ayyanchira · 2025-10-15T20:21:25Z

src/core/classes/IterableApi.ts

Im assuming this replaces the RNIterableApi class. However, I dont see the removal of that file. If it exists, what is it supposed to have?

That's loaded from the native layer, so it doesn't actually replace it

Co-authored-by: Copilot <[email protected]>

lposen added 3 commits October 10, 2025 13:18

feat: implement IterableApi class for calls to native layer

361897f

docs: add documentation comment for IterableApi class

4ee7bdf

refactor: replace RNIterableAPI calls with IterableApi methods in Ite…

f2cf388

…rable class

qltysh bot reviewed Oct 10, 2025

View reviewed changes

src/core/classes/IterableApi.ts Outdated Show resolved Hide resolved

src/core/classes/IterableApi.ts Outdated Show resolved Hide resolved

src/core/classes/IterableApi.ts Outdated Show resolved Hide resolved

src/core/classes/IterableApi.ts Outdated Show resolved Hide resolved

lposen added 2 commits October 10, 2025 13:49

refactor: update IterableApi method signatures to accept destructured…

4da6aa0

… parameters

refactor: replace RNIterableAPI references with IterableApi

efb72a6

lposen added the documentation Improvements or additions to documentation label Oct 10, 2025

Merge branch 'jwt/MOB-11032-task-4-ios-bridge-retrypolicy-and-authfai…

39f07d0

…lure' into jwt/MOB-12231-create-an-iterableapi-class-for-api-calls

lposen changed the base branch from jwt/MOB-10947-task-3-android-retrypolicy-config-at-android-br to jwt/MOB-11032-task-4-ios-bridge-retrypolicy-and-authfailure October 10, 2025 21:40

qltysh bot reviewed Oct 10, 2025

View reviewed changes

example/ios/ReactNativeSdkExample/AppDelegate.swift Show resolved Hide resolved

lposen added 2 commits October 10, 2025 16:49

refactor: simplify inAppManager initialization to avoid circular depe…

fb4b801

…ndencies

feat: add IterableApi and IterableAuthManager exports to core classes

800bb0b

lposen added the jwt label Oct 14, 2025

lposen changed the title ~~[MOB-12231] create-an-iterableapi-class-for-api-calls~~ [MOB-12231] Put all calls to the native layer in a class called IterableApi Oct 14, 2025

lposen mentioned this pull request Oct 14, 2025

[MOB-9064] JWT #740

Draft

Merge branch 'jwt/MOB-11032-task-4-ios-bridge-retrypolicy-and-authfai…

52d5ac4

…lure' into jwt/MOB-12231-create-an-iterableapi-class-for-api-calls

Base automatically changed from jwt/MOB-11032-task-4-ios-bridge-retrypolicy-and-authfailure to jwt/master October 14, 2025 23:32

lposen and others added 2 commits October 14, 2025 16:33

Merge branch 'jwt/master' into jwt/MOB-12231-create-an-iterableapi-cl…

c9fefd7

…ass-for-api-calls

test: add tests to IterableApi

23d719a

lposen removed the documentation Improvements or additions to documentation label Oct 15, 2025

lposen requested review from Ayyanchira and Copilot October 15, 2025 17:20

Copilot AI reviewed Oct 15, 2025

View reviewed changes

src/inApp/classes/IterableInAppManager.ts Outdated Show resolved Hide resolved

Ayyanchira approved these changes Oct 15, 2025

View reviewed changes

Update src/inApp/classes/IterableInAppManager.ts

5517bf7

Co-authored-by: Copilot <[email protected]>

lposen merged commit a2e5177 into jwt/master Oct 16, 2025
4 of 5 checks passed

lposen deleted the jwt/MOB-12231-create-an-iterableapi-class-for-api-calls branch October 16, 2025 00:20

		@@ -1,4 +1,4 @@
		import { RNIterableAPI } from '../../api';
		import { IterableApi } from '../../core/classes/IterableApi';

[MOB-12231] Put all calls to the native layer in a class called IterableApi #737

[MOB-12231] Put all calls to the native layer in a class called IterableApi #737

Uh oh!

Conversation

lposen commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Testing

Uh oh!

github-actions bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qltysh bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qltysh bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

lposen commented Oct 15, 2025

Uh oh!

Ayyanchira left a comment

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

lposen Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

lposen Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

lposen Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lposen commented Oct 10, 2025 •

edited

Loading

github-actions bot commented Oct 10, 2025 •

edited

Loading

qltysh bot commented Oct 10, 2025 •

edited

Loading

qltysh bot commented Oct 10, 2025 •

edited

Loading

github-actions bot commented Oct 10, 2025 •

edited

Loading